[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

serhiy-storchaka commented May 1, 2020 •
edited by bedevere-bot
Loading

It was positional-only de facto: documentation and two implementations
used three different name.

https://bugs.python.org/issue39435

serhiy-storchaka added the type-feature A feature request or enhancement label May 1, 2020
bpo-39435: Make the first argument of pickle.loads() positional-only.
c780578 
It was positional-only de facto: documentation and two implementations
used three different name.
gvanrossum approved these changes May 1, 2020
View reviewed changes
Copy link
Member

gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Copy link
Member Author

serhiy-storchaka commented May 2, 2020

Oh, @gvanrossum and @ilevkivskyi were added to the reviewers list because some experimental changes to typing.py were pushed initially by mistake. Sorry for disturbance.

serhiy-storchaka merged commit 531d1e5 into python:master May 2, 2020
serhiy-storchaka deleted the pickle-loads-posonly branch May 2, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes

ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants