There was a problem hiding this comment.
In the commit message, can you please use the syntax:
Co-Authored-By: full name <name@example.com>
Rather than GitHub names? For me, it's:
Co-Authored-By: Victor Stinner <victor.stinner@gmail.com>
There was a problem hiding this comment.
Commit message:
"Introduced by 1abcf67"
Hum, it was also introduced by 6b4be19. I propose:
Fix regressions introduced by:
- bpo-18520: commit 8fea252a507024edf00d5d98881d22dc8799a8d3
- bpo-22257: commits 1abcf6700b4da6207fe859de40c6c1bada6b4fec and 6b4be195cd8868b76eb6fbe166acc39beee8ce36
There was a problem hiding this comment.
LGTM, let's see if all tests pass ;-)
There was a problem hiding this comment.
I suggest you to revert the warnoptions change and let it open, since it seems tricky to fix it.
There was a problem hiding this comment.
test_capi does crash with this change :-(
There was a problem hiding this comment.
Ok, it should now pass on Travis CI but it doesn't fix the refleak in warnoptions. It's a compromise :-)
Fix regressions introduced by:
Fixed with @Haypo and @mlouielu