[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

cjerdonek commented May 7, 2020 •
edited by bedevere-bot
Loading

This adds a msg argument to Future.cancel() and Task.cancel().

(The C implementation is currently working and tests are added, but I still need to do the pure Python implementation.)

https://bugs.python.org/issue31033

cjerdonek requested review from 1st1 and asvetlov as code owners May 7, 2020 13:57
cjerdonek force-pushed the issue-31033-cancel-msg branch 3 times, most recently from 67ba96f to de9f8b1 Compare May 7, 2020 20:38
cjerdonek changed the title [WIP] bpo-31033: Add a msg argument to Future.cancel() and Task.cancel() bpo-31033: Add a msg argument to Future.cancel() and Task.cancel() May 7, 2020
cjerdonek force-pushed the issue-31033-cancel-msg branch 5 times, most recently from ff02c76 to 6a21d74 Compare May 8, 2020 12:43
1st1 reviewed May 13, 2020
View reviewed changes
cjerdonek mentioned this pull request May 13, 2020
Merged
cjerdonek force-pushed the issue-31033-cancel-msg branch from 6a21d74 to 50cf2a8 Compare May 15, 2020 00:46
Copy link
Member Author

cjerdonek commented May 15, 2020

@1st1 I removed the exception helper like you requested (inlining the logic instead, like you suggested). Can you take another look?

cjerdonek force-pushed the issue-31033-cancel-msg branch from 50cf2a8 to 22a54cc Compare May 15, 2020 01:34
Copy link
Member Author

cjerdonek commented May 15, 2020

Force-pushed to unstick CI..

1st1 reviewed May 15, 2020
View reviewed changes
1st1 approved these changes May 15, 2020
View reviewed changes
Copy link
Member

1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cjerdonek merged commit 1ce5841 into python:master May 15, 2020
cjerdonek deleted the issue-31033-cancel-msg branch May 15, 2020 23:55
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
bpo-31033: Add a msg argument to Future.cancel() and Task.cancel() (p…
7654bbb 
…ythonGH-19979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 1st1 approved these changes

asvetlov Awaiting requested review from asvetlov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants