[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

serhiy-storchaka commented May 11, 2020 •
edited by bedevere-bot
Loading

serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label May 11, 2020
vstinner reviewed May 11, 2020
View reviewed changes
Objects/unicodeobject.c Outdated
{
/* Since there is no way to return an error from PyUnicode_IsIdentifier()
we have to call PyUnicode_READY() to ensure that the string object is
in the "canonical" representation. */
Copy link
Member

vstinner May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this comment is worth it. It's something usual to report an error when a function fails. All functions in this file does that. I suggest to remove the comment.

serhiy-storchaka commented May 12, 2020
View reviewed changes
Apply suggestions from code review
750d91f 
Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka mentioned this pull request May 12, 2020
Merged
serhiy-storchaka deleted the isidentifier-legacy branch May 12, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments

Assignees

No one assigned

Labels

awaiting core review type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants