[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

gousaiyang commented Jul 4, 2020 •
edited by bedevere-bot
Loading

Copy link
Member

matrixise commented Jul 6, 2020

Hello @gousaiyang

Thank you for your contribution, really appreciated.

Could you add some tests, for example, you could check in Lib/tests/test_audit.py if you need some pointers.

Copy link
Contributor Author

gousaiyang commented Oct 8, 2020

Hi @matrixise. If you had time could you review this PR again? Thanks!

matrixise self-assigned this Apr 22, 2021
Copy link
Member

matrixise commented Apr 22, 2021

Hi @gousaiyang

Your PR is on my list. I will check it asap.

Thank you

matrixise merged commit 927b841 into python:master Apr 23, 2021
Copy link
Member

matrixise commented Apr 23, 2021

Just forgot to approve the branch, but everything seems fine to me.

@gousaiyang Thank you for your contribution, this one will be only in 3.10

gousaiyang deleted the audit-http-client branch April 23, 2021 18:24
zooba mentioned this pull request Nov 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

matrixise

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants