[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

vxgmichel commented Sep 7, 2017 •
edited by bedevere-bot
Loading

berkerpeksag requested changes Oct 31, 2017
View reviewed changes
Lib/test/test_configparser.py
cf = self.newconfig()
parsed_files = cf.read([])
self.assertEqual(parsed_files, [])
# check when passing an existing bytestring path
Copy link
Member

berkerpeksag Oct 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_read_returns_file_list is already too long, could you move it a separate test case?

Misc/NEWS.d/next/Library/2017-09-07-12-50-28.bpo-31307.AVBiNY.rst Outdated
@@ -0,0 +1 @@
Allow use of bytes objects for arguments to configparser.ConfigParser.read.
Copy link
Member

berkerpeksag Oct 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "Patch by Vincent Michel.".

Misc/NEWS.d/next/Library/2017-09-07-12-50-28.bpo-31307.AVBiNY.rst Outdated
@@ -0,0 +1 @@
Allow use of bytes objects for arguments to configparser.ConfigParser.read.
Copy link
Member

berkerpeksag Oct 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:meth:`configparser.ConfigParser.read`

Copy link

bedevere-bot commented Oct 31, 2017

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Contributor Author

vxgmichel commented Nov 2, 2017

@berkerpeksag Thanks for the review. I have made the requested changes; please review again.

Copy link

bedevere-bot commented Nov 2, 2017

Thanks for making the requested changes!

@merwok, @berkerpeksag: please review the changes made to this pull request.

berkerpeksag merged commit e314853 into python:master Nov 2, 2017
Copy link
Member

berkerpeksag commented Nov 2, 2017

Thanks!

vxgmichel deleted the bpo-31307 branch November 2, 2017 12:53
Copy link
Contributor

ambv commented Nov 2, 2017

Thanks! ✨ 🍰 ✨

embray pushed a commit to embray/cpython that referenced this pull request Nov 9, 2017
bpo-31307: Make ConfigParser.read() accept bytes objects (pythonGH-3420)
a68756e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

berkerpeksag berkerpeksag approved these changes

merwok merwok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants