[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Sep 13, 2017 •
edited by bedevere-bot
Loading

(cherry picked from commit a5b4ea1)

https://bugs.python.org/issue31271

bedevere-bot mentioned this pull request Sep 13, 2017
Merged
Copy link

the-knights-who-say-ni commented Sep 13, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

Copy link
Member

vstinner commented Sep 13, 2017

Test failed:

======================================================================

FAIL: test_illegal_encoder (test.test_io.CTextIOWrapperTest)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/python/cpython/Lib/test/test_io.py", line 2675, in test_illegal_encoder

    self.assertRaises(TypeError, t.write, 'bar')

AssertionError: TypeError not raised

======================================================================

FAIL: test_illegal_encoder (test.test_io.PyTextIOWrapperTest)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/python/cpython/Lib/test/test_io.py", line 2675, in test_illegal_encoder

    self.assertRaises(TypeError, t.write, 'bar')

AssertionError: TypeError not raised

Mariatta mentioned this pull request Sep 13, 2017
Closed
Copy link
Member

Mariatta commented Sep 13, 2017

Thanks @Haypo. Does @orenmn (who made the PR) or @serhiy-storchaka (who merged the PR) want to prepare the backport PR?

I also opened python/miss-islington#26 for some ideas of what @miss-islington can do in the future to handle this situation.

Mariatta closed this Sep 16, 2017
miss-islington deleted the backport-a5b4ea1-2.7 branch September 16, 2017 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants