[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

1st1 commented Oct 6, 2017 •
edited
Loading

1st1 requested a review from rhettinger as a code owner October 6, 2017 04:28
1st1 requested review from ncoghlan and removed request for rhettinger October 6, 2017 04:29
ncoghlan approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo in the docs, but otherwise LGTM!

Doc/reference/datamodel.rst Outdated
.. versionchanged:: 3.7
Prior to Python 3.7, ``__aiter__`` could return an *awaitable*
that would resolve to an
:term:`asynchronous iterators <asynchronous iterator>`.
Copy link
Contributor

ncoghlan Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: you don't want the s here.

Copy link
Member Author

1st1 commented Oct 6, 2017

Thanks, Nick!

1st1 merged commit faa135a into python:master Oct 6, 2017
1st1 deleted the aiter_nocompat branch October 6, 2017 06:09
1st1 mentioned this pull request Oct 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants