[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Oct 24, 2017 •
edited by bedevere-bot
Loading

test_unparse.DirectoryTestCase now stores the names sample to always
test the same files. It prevents false alarms when hunting reference
leaks.
(cherry picked from commit 8e482be)

https://bugs.python.org/issue31174

bpo-31174: Fix test_tools.test_unparse (pythonGH-4102)
10a2285 
test_unparse.DirectoryTestCase now stores the names sample to always
test the same files. It prevents false alarms when hunting reference
leaks.
(cherry picked from commit 8e482be)
bedevere-bot mentioned this pull request Oct 24, 2017
Merged
vstinner approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Copy link
Contributor Author

miss-islington commented Oct 24, 2017

@Haypo: Backport status check is done, and it's a success ✅ .

vstinner merged commit d8f78a1 into python:3.6 Oct 24, 2017
Copy link
Contributor Author

miss-islington commented Oct 24, 2017

Thanks, @Haypo!

miss-islington deleted the backport-8e482be-3.6 branch October 24, 2017 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants