bpo-18533: Avoid RuntimeError from repr() of recursive dictview by bennorth · Pull Request #4823 · python/cpython

…-4823)

dictview_repr(): Use a Py_ReprEnter() / Py_ReprLeave() pair to check
for recursion, and produce "..." if so.

test_recursive_repr(): Check for the string rather than a
RecursionError.  (Test cannot be any tighter as contents are
implementation-dependent.)

test_deeply_nested_repr(): Add new test, replacing the original
test_recursive_repr().  It checks that a RecursionError is raised in
the case of a non-recursive but deeply nested structure.  (Very
similar to what test_repr_deep() in test/test_dict.py does for a
normal dict.)

OrderedDictTests: Add new test case, to test behavior on OrderedDict
instances containing their own values() or items().
(cherry picked from commit d7773d9)

…on#4823)

dictview_repr(): Use a Py_ReprEnter() / Py_ReprLeave() pair to check
for recursion, and produce "..." if so.

test_recursive_repr(): Check for a string rather than a
RuntimeError.  (Test cannot be any tighter as contents are
implementation-dependent.)

test_deeply_nested_repr(): Add new test, replacing the original
test_recursive_repr().  It checks that a RuntimeError is raised in
the case of a non-recursive but deeply nested structure.

OrderedDictTests: Add new test case, to test behavior on OrderedDict
instances containing their own viewvalues() or viewitems().  This test
passes without the patch to dictview_repr(), but it failed in (at
least some versions of) Python 3, so including it here for
completeness.

(cherry picked from commit d7773d9)