[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

bbayles commented Jan 11, 2018

This PR adds the capture_output parameter to subprocess.run, as described in issue 32102.

I have been pleased to see the subprocess getting easier to use over the last few releases, and was happy to see the idea for replacing subprocess.run(..., stdin=subprocess.PIPE, stdout=subprocess.PIPE) with something friendlier had already been proposed.

https://bugs.python.org/issue32102

Copy link
Member

warsaw commented Jan 11, 2018

Looks like there's an incorrect reference to issue 32248 in the description.

bbayles changed the title bpo-32248 Add "capture_output=True" option to subprocess.run bpo-32102 Add "capture_output=True" option to subprocess.run Jan 11, 2018
Copy link
Contributor Author

bbayles commented Jan 11, 2018

Whoops, you're right. Not sure how I did that. 32102 is the correct issue number.

I've fixed the description and reference. However, my branch name is still incorrect. Does that matter? If so I can close this PR and open a new one with a better branch name.

Copy link
Member

warsaw commented Jan 11, 2018

The branch name doesn't technically matter, so that's entirely up to you. Thanks for fixing things.

this keeps the old description of *text* and makes the *capture_output* mention its own sentence.
gpshead added the type-feature A feature request or enhancement label Jan 30, 2018
gpshead self-assigned this Jan 30, 2018
gpshead merged commit ce0f33d into python:master Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants