[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Feb 20, 2018

Initialize self._ssnd_chunk so that aifc.Error is raised as intended,
not AttributeError.
(cherry picked from commit 80d20b9)

Co-authored-by: Zackery Spytz zspytz@gmail.com

https://bugs.python.org/issue31848

…SND chunk is not found (pythonGH-5240)

Initialize self._ssnd_chunk so that aifc.Error is raised as intended,
not AttributeError.
(cherry picked from commit 80d20b9)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Copy link
Contributor Author

@ZackerySpytz and @serhiy-storchaka: Backport status check is done, and it's a failure ❌ .

Copy link
Contributor

The backport to 2.7 needs to use assertRaisesRegexp() instead of assertRaisesRegex().

serhiy-storchaka dismissed their stale review February 20, 2018 22:11

May need manual editing of the commit message.

Copy link
Member

@serhiy-storchaka I think miss-islington won't auto merge since you made an additional commit. So you'll have to merge this PR manually. It also failed to report the new status check.

Copy link
Member

I dismissed my approve for preventing auto merge because I didn't know how @miss-islington handles the case of multiple commits.

serhiy-storchaka merged commit b852d8c into python:2.7 Feb 21, 2018
Copy link
Contributor Author

Thanks, @serhiy-storchaka!

Copy link
Member

It's not yet handling the multiple commits case :)
I've opened this issue to track it. python/miss-islington#64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants