[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

zhangyangyu commented Mar 10, 2018 •
edited by bedevere-bot
Loading

zhangyangyu added the type-feature A feature request or enhancement label Mar 10, 2018
serhiy-storchaka reviewed Mar 10, 2018
View reviewed changes
Modules/_struct.c Outdated
if (offset < 0) {
if (offset + self->s_size > 0) {
PyErr_Format(StructError,
"no space to unpack %zd bytes at offset %zd",
Copy link
Member

serhiy-storchaka Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would better sound as "not enough data" or like.

Copy link
Member Author

zhangyangyu Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. That's my first draft.

zhangyangyu merged commit c10b288 into python:master Mar 10, 2018
zhangyangyu deleted the issue30249 branch March 10, 2018 18:58
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
bpo-30249: Improve struct.unpack_from() error messages (pythonGH-6059)
1cf765b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants