[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

methane commented Mar 23, 2018 •
edited by bedevere-bot
Loading

ilevkivskyi approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member

ilevkivskyi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch!

methane merged commit c65bf3f into python:master Mar 23, 2018
Copy link
Contributor

miss-islington commented Mar 23, 2018

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

methane deleted the bpo32999-assert branch March 23, 2018 09:19
Copy link

bedevere-bot commented Mar 23, 2018

GH-6198 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2018
bpo-32999: ast: Convert useless check to assert (pythonGH-6197)
88711d0 
(cherry picked from commit c65bf3f)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 23, 2018
bpo-32999: ast: Convert useless check to assert (GH-6197)
c71edab 
(cherry picked from commit c65bf3f)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants