[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Apr 27, 2018 •
edited by bedevere-bot
Loading

Fix test_embed.test_pre_initialization_sys_options() when building with --enable-shared
(cherry picked from commit 4114846)

Co-authored-by: Pablo Galindo Pablogsal@gmail.com

https://bugs.python.org/issue33358

bpo-33358: Fix test_embed.test_pre_initialization_sys_options (python…
9ba7e04 
…GH-6612)

Fix test_embed.test_pre_initialization_sys_options() when building with --enable-shared
(cherry picked from commit 4114846)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
bedevere-bot mentioned this pull request Apr 27, 2018
Merged
vstinner approved these changes Apr 27, 2018
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Copy link
Member

vstinner commented Apr 27, 2018

I tested manually Python 3.7 with --enabled-shared: test_embed fails without this change, and pass with this change.

Copy link
Member

vstinner commented Apr 27, 2018

cc @pablogsal

Copy link
Contributor Author

miss-islington commented Apr 27, 2018

@pablogsal and @vstinner: Backport status check is done, and it's a success ✅ .

miss-islington merged commit dd3ede7 into python:3.7 Apr 27, 2018
Copy link
Contributor Author

miss-islington commented Apr 27, 2018

Thanks!

miss-islington deleted the backport-4114846-3.7 branch April 27, 2018 12:41
Copy link
Member

vstinner commented Apr 27, 2018

@pablogsal and @vstinner: Backport status check is done, and it's a success white_check_mark .

Oh wow, that was fast. Now I really saw that bot doing an actual merge. Impressive work @Mariatta!

Copy link
Member

vstinner commented Apr 27, 2018

Thanks again, good bot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants