[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

serhiy-storchaka commented May 12, 2018

Also make getchildren() and getiterator() emitting a DeprecationWarning instead of PendingDeprecationWarning.

https://bugs.python.org/issue29209

Also make getchildren() and getiterator() emitting
a DeprecationWarning instead of PendingDeprecationWarning.
serhiy-storchaka force-pushed the etree-remove-deprecated branch from 37b9b3b to 3207edc Compare May 12, 2018 10:18
"This method will be removed in future versions. "
"Use 'tree.iter()' or 'list(tree.iter())' instead.",
PendingDeprecationWarning, stacklevel=2
DeprecationWarning, stacklevel=2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to update the messages to have the version since the deprecation and the planned removal version here (and on line 418) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in the documentation.

warnings.warn(
"The doctype() method of XMLParser is ignored. "
"Define doctype() method on the TreeBuilder target.",
RuntimeWarning)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here add versions ?

serhiy-storchaka merged commit 02ec92f into python:master Jul 24, 2018
serhiy-storchaka deleted the etree-remove-deprecated branch July 24, 2018 09:03
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants