[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented May 15, 2018 •
edited by bedevere-bot
Loading

Don't crash on warnings.warn_explicit() if module_globals is not a dict.
(cherry picked from commit b056562)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue33509

bpo-33509: Fix _warnings for module_globals=None (pythonGH-6833)
3d6fed8 
Don't crash on warnings.warn_explicit() if module_globals is not a dict.
(cherry picked from commit b056562)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
bedevere-bot mentioned this pull request May 15, 2018
Merged
vstinner approved these changes May 15, 2018
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Copy link
Contributor Author

miss-islington commented May 15, 2018

@vstinner: Backport status check is done, and it's a success ✅ .

miss-islington merged commit 820219f into python:3.7 May 15, 2018
Copy link
Contributor Author

miss-islington commented May 15, 2018

Thanks!

miss-islington deleted the backport-b056562-3.7 branch May 15, 2018 20:56
Copy link
Member

vstinner commented May 16, 2018

"@miss-islington: Thanks!"

Oh. You're welcome. It was a pleasure to work with you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants