[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented May 20, 2018 •
edited by bedevere-bot
Loading

uuid._ipconfig_getnode did not validate the maximum length of the value,
so long as the value had the same type of formatting as a MAC address.
This let it select DUIDs as MAC addresses. It now requires an exact
length match.
(cherry picked from commit c66c342)

Co-authored-by: CtrlZvi viz+github@flippedperspective.com

https://bugs.python.org/issue33542

bpo-33542: Ignore DUID in uuid.get_node on Windows. (pythonGH-6922)
27cfd8f 
uuid._ipconfig_getnode did not validate the maximum length of the value,
so long as the value had the same type of formatting as a MAC address.
This let it select DUIDs as MAC addresses. It now requires an exact
length match.
(cherry picked from commit c66c342)

Co-authored-by: CtrlZvi <viz+github@flippedperspective.com>
bedevere-bot added the type-bug An unexpected behavior, bug, or error label May 20, 2018
bedevere-bot mentioned this pull request May 20, 2018
Merged
Copy link
Contributor Author

miss-islington commented May 20, 2018

@CtrlZvi and @serhiy-storchaka: Backport status check is done, and it's a success ✅ .

miss-islington merged commit 073eca3 into python:3.7 May 20, 2018
Copy link
Contributor Author

miss-islington commented May 20, 2018

Thanks!

miss-islington deleted the backport-c66c342-3.7 branch May 20, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants