[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

corona10 commented May 29, 2018 •
edited by bedevere-bot
Loading

This PR is originated from a discussion #6636 (comment)

https://bugs.python.org/issue33197

corona10 force-pushed the bpo-33197-2 branch 2 times, most recently from 85c7cf0 to 723ef05 Compare May 29, 2018 15:50
Copy link
Member Author

corona10 commented May 29, 2018

@1st1 Last PR which is related with bpo-33197 PTAL

1st1 requested changes May 29, 2018
View reviewed changes
Copy link
Member

1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs.

Copy link

bedevere-bot commented May 29, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

corona10 force-pushed the bpo-33197-2 branch 3 times, most recently from 55c98ec to e8900d0 Compare May 30, 2018 05:08
Copy link
Member Author

corona10 commented May 30, 2018

@1st1
I have made the requested changes; please review again

Copy link

bedevere-bot commented May 30, 2018

Thanks for making the requested changes!

@1st1: please review the changes made to this pull request.

Copy link
Member Author

corona10 commented Jun 4, 2018

@1st1
Please take a look if you have a time :)

1st1 merged commit 4aa3006 into python:master Jun 8, 2018
corona10 deleted the bpo-33197-2 branch June 8, 2018 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 1st1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants