There was a problem hiding this comment.
I don't think that it's correct to use ".. versionchanged:: 3.8" tag in Python 2.7. Just add a regular paragraph before ".. versionadded:: 2.6".
There was a problem hiding this comment.
please add "Python": since Python 3.5 ... removed in Python 3.8
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
6e38377 to
2550180
Compare
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
There was a problem hiding this comment.
LGTM, but I would prefer to have a second review from a second core developer, but I'm not 100% sure that we should document this Python 3 change in the Python 2.7 doc.
|
This has some precedent in e.g. urllib docs. |
I looked at the HTML output. Honestly, if you don't read carefully the whole documentation, you can easily miss the new note. I modified the doc to use a ".. note::" and I agree that it's much easier to catch this note. So yes, please, @timofurrer: modify your PR to write the new paragraph as a note. |
2550180 to
f78323c
Compare
|
@vstinner done! |
|
@timofurrer: Thank you Timo Furrer for your contribution! It's better as the note ;-) Thanks @encukou for the review as well. |
This change addresses the issue here: https://bugs.python.org/issue33600
Is there a better marker than
.. versionchanged::for this? I tried to find similar situations, but couldn't find any. Maybe someone could point me to one?https://bugs.python.org/issue33600