[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented May 31, 2018 •
edited by bedevere-bot
Loading

Fix a crash in Python initialization when parsing the command line
options.

Fix memcpy() size parameter: previously, we read one wchar_t after
the end of _PyOS_optarg. Moreover, don't copy the trailingg NUL
character: we write it manually anyway.

Thanks Christoph Gohlke for the bug report and the fix!
(cherry picked from commit 58d1683)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue33706

bpo-33706: Fix pymain_parse_cmdline_impl() (pythonGH-7283)
1c5c691 
Fix a crash in Python initialization when parsing the command line
options.

Fix memcpy() size parameter: previously, we read one wchar_t after
the end of _PyOS_optarg. Moreover, don't copy the trailingg NUL
character: we write it manually anyway.

Thanks Christoph Gohlke for the bug report and the fix!
(cherry picked from commit 58d1683)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
bedevere-bot mentioned this pull request May 31, 2018
Merged
vstinner approved these changes May 31, 2018
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Copy link
Contributor Author

miss-islington commented May 31, 2018

@vstinner: Backport status check is done, and it's a success ✅ .

miss-islington merged commit c6de46e into python:3.7 May 31, 2018
Copy link
Contributor Author

miss-islington commented May 31, 2018

Thanks!

miss-islington deleted the backport-58d1683-3.7 branch May 31, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants