[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Jun 4, 2018 •
edited by bedevere-bot
Loading

Fix test_warnings.test_module_globals() when python3 is run with
-Werror.
(cherry picked from commit e292b75)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue33509

bpo-33509: Fix test_warnings for python3 -Werror (pythonGH-7365)
af9e505 
Fix test_warnings.test_module_globals() when python3 is run with
-Werror.
(cherry picked from commit e292b75)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
bedevere-bot mentioned this pull request Jun 4, 2018
Merged
vstinner approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Copy link
Contributor Author

miss-islington commented Jun 4, 2018

@vstinner and @ned-deily: Backport status check is done, and it's a success ✅ .

2 similar comments
Copy link
Contributor Author

miss-islington commented Jun 4, 2018

@vstinner and @ned-deily: Backport status check is done, and it's a success ✅ .

Copy link
Contributor Author

miss-islington commented Jun 4, 2018

@vstinner and @ned-deily: Backport status check is done, and it's a success ✅ .

miss-islington merged commit d2c6ecc into python:3.7 Jun 4, 2018
Copy link
Contributor Author

miss-islington commented Jun 4, 2018

Thanks!

miss-islington deleted the backport-e292b75-3.7 branch June 4, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants