[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

vstinner commented Jun 4, 2018

  • test_tempfile.test_no_leak_fd() mocks os.close() but it doesn't
    call the original os.close() method and so leaks an open file
    descriptor. Fix the test by calling the original os.close()
    function.
  • test_posix.test_fdopen_directory(): close the directory file
    descriptor when the test completes.

https://bugs.python.org/issue18174

* test_tempfile.test_no_leak_fd() mocks os.close() but it doesn't
  call the original os.close() method and so leaks an open file
  descriptor. Fix the test by calling the original os.close()
  function.
* test_posix.test_fdopen_directory(): close the directory file
  descriptor when the test completes.
vstinner merged commit 2705819 into python:2.7 Jun 4, 2018
vstinner deleted the fix_fdleak27 branch June 4, 2018 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants