[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

jdemeyer commented Jun 7, 2018

Copy link
Member

methane commented Jun 7, 2018

While the title says "extensions", isn't this affects all CPython source?

Anyway, I don't think it's worth enough to backporting.
It only suppress some noise while compiling C++ extensions. It's not so critical problem.
We lived with them for several (or dozen) years.

Python 2.7.16 will be released on late 2018 or early 2019.
But how many people use it? Any major distributions will preinstall it?

jdemeyer changed the title [2.7] bpo-5755: don't compile extensions with -Wstrict-prototypes (GH-7395) [2.7] bpo-5755: don't use compiler flag -Wstrict-prototypes (GH-7395) Jun 7, 2018
Copy link
Contributor Author

jdemeyer commented Jun 7, 2018

While the title says "extensions", isn't this affects all CPython source?

Right, I fixed the title.

Anyway, I don't think it's worth enough to backporting.
It only suppress some noise while compiling C++ extensions. It's not so critical problem.
We lived with them for several (or dozen) years.

The fact that a bug is not critical and has existed for a long time is a bad excuse to not fix it. It's still a bug.

Copy link
Member

methane commented Jun 7, 2018

The fact that a bug is not critical and has existed for a long time is a bad excuse to not fix it. It's still a bug.

I agree if there are enough resource (core developer's time and energy for review and discussion).

In this pull request, there is downside, and I don't think it's worth enough to use time and energy for discussion about the downside.

If proposed fix is easy to review, low risk to degrade, and has no downside, I'm OK to merge it.

Copy link
Contributor Author

jdemeyer commented Jun 7, 2018

I this case, I would argue that the downside (removing -Wstrict-prototypes when compiling CPython) is so small that it doesn't really matter. But of course, I'm not the one to judge that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants