[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Jun 9, 2018 •
edited by bedevere-bot
Loading

  • bugfix and test for fragile metavar handling in argparse (see
    bpo-24089, bpo-14046, bpo-25058, bpo-11874)
  • also fixes some incorrect tests that did not make 1-element tuples correctly
    (cherry picked from commit 66f02aa)

Co-authored-by: wim glenn wim.glenn@gmail.com

https://bugs.python.org/issue11874

bpo-11874: fix assertion failure in argparse metavar handling (python…
e38ee54 
…GH-1826)

- bugfix and test for fragile metavar handling in argparse (see
  bpo-24089, bpo-14046, bpo-25058, bpo-11874)
- also fixes some incorrect tests that did not make 1-element tuples correctly
(cherry picked from commit 66f02aa)

Co-authored-by: wim glenn <wim.glenn@gmail.com>
bedevere-bot mentioned this pull request Jun 9, 2018
Merged
Copy link
Contributor Author

miss-islington commented Jun 9, 2018

@wimglenn and @ncoghlan: Backport status check is done, and it's a success ✅ .

1 similar comment
Copy link
Contributor Author

miss-islington commented Jun 9, 2018

@wimglenn and @ncoghlan: Backport status check is done, and it's a success ✅ .

miss-islington merged commit 4e6bd24 into python:2.7 Jun 9, 2018
Copy link
Contributor Author

miss-islington commented Jun 9, 2018

Thanks!

miss-islington deleted the backport-66f02aa-2.7 branch June 9, 2018 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants