[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

zhangyangyu commented Jun 19, 2018 •
edited by bedevere-bot
Loading

I suggest using platform.platform(aliased=True, terse=True) in test.pythoninfo in < 3.8. This makes it more consistent with 3.8. platform.platform is largely changed in 3.8. More specially, I want libc version to be included in pythoninfo. Although libc version is wrong now but I think it will be fixed soon.

https://bugs.python.org/issue33717

zhangyangyu requested a review from vstinner June 19, 2018 15:28
vstinner changed the title set terse=True in pythoninfo.collect_platform bpo-33717: set terse=True in pythoninfo.collect_platform Jun 19, 2018
vstinner reviewed Jun 19, 2018
View reviewed changes
Lib/test/pythoninfo.py
platform.python_implementation())
info_add('platform.platform',
platform.platform(aliased=True))
platform.platform(aliased=True, terse=True))
Copy link
Member

vstinner Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like terse=True returns less information.

platform.platform(aliased=True)
'Linux-4.16.14-300.fc28.x86_64-x86_64-with-fedora-28-Twenty_Eight'
platform.platform(aliased=True,terse=True)
'Linux-4.16.14-300.fc28.x86_64-x86_64-with-glibc2.3.4'

Copy link
Member Author

zhangyangyu Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distribution info. platform.dist is deprecated long ago and the buildbot already tells us what the exact distribution is. The info is already not available in master.

vstinner approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

zhangyangyu merged commit 71ca738 into python:3.7 Jun 19, 2018
Copy link
Contributor

miss-islington commented Jun 19, 2018

Thanks @zhangyangyu for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

zhangyangyu deleted the pythoninfo-platform branch June 19, 2018 17:33
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2018
set terse to True when calling platform.platform in test.pythoninfo (p…
2d347f8 
…ythonGH-7797)

(cherry picked from commit 71ca738)

Co-authored-by: Xiang Zhang <angwerzx@126.com>
Copy link

bedevere-bot commented Jun 19, 2018

GH-7802 is a backport of this pull request to the 3.6 branch.

Copy link

bedevere-bot commented Jun 19, 2018

GH-7803 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2018
set terse to True when calling platform.platform in test.pythoninfo (p…
048f32b 
…ythonGH-7797)

(cherry picked from commit 71ca738)

Co-authored-by: Xiang Zhang <angwerzx@126.com>
zhangyangyu added a commit that referenced this pull request Jun 19, 2018
bpo-33717: set terse to True when calling platform.platform in test.p…
b2dd5f1 
…ythoninfo (GH-7797) (GH-7803)

(cherry picked from commit 71ca738)

Co-authored-by: Xiang Zhang <angwerzx@126.com>
zhangyangyu added a commit that referenced this pull request Jun 19, 2018
bpo-33717: set terse to True when calling platform.platform in test.p…
6aa283a 
…ythoninfo (GH-7797) (GH-7802)

(cherry picked from commit 71ca738)

Co-authored-by: Xiang Zhang <angwerzx@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants