[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link

laomaiweng commented Jun 22, 2018

In Modules/_hashopenssl.c, the OPENSSL_VERSION_1_1 macro is checked for in PyInit__hashlib(), but never defined.

This causes build failures with some OpenSSL 1.1.

Define it when appropriate, using the logic from Modules/_ssl.c.

https://bugs.python.org/issue33936

This #define is currently checked for in PyInit__hashlib(), but never defined. Define it when appropriate, using the logic from Modules/_ssl.c.
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Author

CLA signed, can someone remove the tag please? Thanks!

csabella requested review from tiran and removed request for tiran May 18, 2019 12:02
Copy link
Member

tiran commented Sep 14, 2019

Hi, thanks for your PR.

There were some minor issues with your PR (missing news, conflicts) and I decided to go for a slightly different approach in PR #16140 16140

tiran closed this Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants