[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

serhiy-storchaka commented Jul 3, 2018 •
edited by bedevere-bot
Loading

This may reduce the stack consumption for unmarshalling deeply
nested structures.

https://bugs.python.org/issue33720

serhiy-storchaka added type-feature A feature request or enhancement skip news labels Jul 3, 2018
bpo-33720: Refactor marshalling/unmarshalling floats.
282cf4f 
This may reduce the stack consumption for unmarshalling deeply
nested structures.
serhiy-storchaka force-pushed the marshal-floats-refactoring branch from 979d682 to 282cf4f Compare July 4, 2018 05:29
Copy link
Member Author

serhiy-storchaka commented Jul 24, 2018

Unfortunately the goal is not achieved. This change doesn't reduce stack consumption in the PGO build on Windows (which is around 1600 bytes per level, much more than 256 bytes for the buffer). I'm merging this PR in master only just as refactoring.

serhiy-storchaka merged commit c573499 into python:master Jul 24, 2018
serhiy-storchaka deleted the marshal-floats-refactoring branch July 24, 2018 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

methane methane approved these changes

zooba zooba approved these changes

Assignees

No one assigned

Labels

skip news type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants