[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

methane commented Jul 19, 2018

There are some same consts in a module. This commit merges them into
single instance. It reduces number of objects in memory after loading modules.

https://bugs.python.org/issue34100

Copy link
Contributor

asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't really review the code -- sorry about the drive-by!

methane closed this Sep 13, 2018
methane reopened this Sep 13, 2018
methane changed the title bpo-34100: compile: Merge constants bpo-34100: Merge constants recursively Sep 13, 2018
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the overall idea. But I don't have the bandwidth to review reference counting and other subtle details.

Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

methane closed this Nov 26, 2018
methane reopened this Nov 26, 2018
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member Author

methane commented Nov 26, 2018

Thank you for review.

... Travis seems very unresponsible...

Copy link
Contributor

@methane: Status check is done, and it's a success ✅ .

miss-islington merged commit c2e1607 into python:master Nov 26, 2018
methane deleted the merge-consts branch November 29, 2018 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants