[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

vstinner commented Aug 1, 2018 •
edited by bedevere-bot
Loading

  • Move config_() and PyCoreConfig() functions from Modules/main.c
    to a new Python/config.c file.
  • Inline _Py_ReadHashSeed() into config_init_hash_seed()

https://bugs.python.org/issue34170

vstinner requested a review from a team as a code owner August 1, 2018 14:56
vstinner requested a review from a team August 1, 2018 15:20
vstinner changed the title bpo-34170: Add Python/config.c for _PyCoreConfig bpo-34170: Add Python/coreconfig.c for _PyCoreConfig Aug 1, 2018
bpo-34170: Add Python/coreconfig.c for _PyCoreConfig
e54533d 
* Add Include/coreconfig.h
* Move config_*() and _PyCoreConfig_*() functions from Modules/main.c
  to a new Python/coreconfig.c file.
* Inline _Py_ReadHashSeed() into config_init_hash_seed()
* Move global configuration variables to coreconfig.c
vstinner merged commit 6c785c0 into python:master Aug 1, 2018
vstinner deleted the config_c branch August 1, 2018 15:56
Copy link
Contributor

ncoghlan commented Aug 4, 2018

Nice! Hooray for moving that out of the main module :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants