[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

vstinner commented Aug 2, 2018

  • Inline pymain_run_file() and pymain_open_filename() into
    pymain_run_filename()
  • Created pymain_run_stdin() which is pymain_run_filename() with
    filename=NULL
  • Rename pymain_run_filename() to pymain_run_file()

https://bugs.python.org/issue34170

* Inline pymain_run_file() and pymain_open_filename() into
  pymain_run_filename()
* Created pymain_run_stdin() which is pymain_run_filename() with
  filename=NULL
* Rename pymain_run_filename() to pymain_run_file()
vstinner merged commit 72ec319 into python:master Aug 2, 2018
vstinner deleted the pymain_run_filename branch August 2, 2018 17:34
PyErr_SetFromErrnoWithFilename(PyExc_OSError,
startup);
PyErr_Print();
PyErr_Clear();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to call PyErr_Clear() after PyErr_Print().

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is 11 years old, I didn't touch it. Please open a new issue if you want to fix it.

See commit e69a08e.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed in 8b58468.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants