[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

danishprakash commented Aug 29, 2018

[WIP] repr of a class should return qualname and
not name especially in nested classes

https://bugs.python.org/issue34443

Copy link
Member

ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making some modifications to how module and qualname are stored (will have have those commits in shortly, I hope). After those land, just need to update all the test_enum repr() tests.

Copy link
Contributor Author

@ethanfurman is there another PR in parallel to this? Anyway, waiting on it.

Copy link
Contributor

@danishprakash @ethanfurman I'm triaging open PRs. It looks like the next steps here are:

  • status update: verify or update test_enum repr() tests
  • Rerun tests in this PR

Copy link
Member

Thanks for the bump, @willingc. I have actually decided not to make this change. @danishprakash, thank you for your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants