[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

ZackerySpytz commented Aug 30, 2018

Previously, put() and get() would raise AssertionError and OSError,
respectively.

https://bugs.python.org/issue22872

…or if the queue is closed

Previously, put() and get() would raise AssertionError and OSError,
respectively.
ZackerySpytz force-pushed the bpo-22872-mp-queue-closed-exceptions branch from da93ab3 to 4256c86 Compare August 30, 2018 22:10
Copy link

auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

def test_closed_queue_put_get_exceptions(self):
for q in multiprocessing.Queue(), multiprocessing.JoinableQueue():
q.close()
for meth, args in (q.put, ('foo',)), (q.get, ()):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would look clearer (and just one line longer) if unroll this loop.

Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

serhiy-storchaka merged commit 0461704 into python:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants