[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

zware commented Sep 4, 2018 •
edited by bedevere-bot
Loading

Check for functionality via imports rather than checking sys.platform
specifically for Windows

https://bugs.python.org/issue8110

bpo-8110: Refactor platform detection in subprocess
bffb9a4 
Check for functionality via imports rather than checking sys.platform
specifically for Windows
zware requested a review from gpshead as a code owner September 4, 2018 05:02
vstinner approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pppery reviewed Sep 8, 2018
View reviewed changes
Lib/subprocess.py
try:
import msvcrt
import _winapi
_mswindows = True
Copy link

pppery Sep 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in the "else" block?

Copy link
Member

gpshead Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _mswindows = True? sure, it could be. But it doesn't matter.

zware merged commit 880d42a into python:master Sep 10, 2018
zware deleted the issue8110 branch September 10, 2018 23:16
zware mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes

vstinner vstinner approved these changes

+1 more reviewer

pppery pppery left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants