[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Sep 7, 2018 •
edited by bedevere-bot
Loading

When calling tp_descr_get(self, obj, type), make sure that
we own a strong reference to "self".
(cherry picked from commit 8f73548)

Co-authored-by: jdemeyer jdemeyer@cage.ugent.be

https://bugs.python.org/issue25750

bpo-25750: fix refcounts in type_getattro() (pythonGH-6118)
f3b9b26 
When calling tp_descr_get(self, obj, type), make sure that
we own a strong reference to "self".
(cherry picked from commit 8f73548)

Co-authored-by: jdemeyer <jdemeyer@cage.ugent.be>
bedevere-bot mentioned this pull request Sep 7, 2018
Merged
vstinner approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot 🤖!

Copy link
Contributor Author

miss-islington commented Sep 7, 2018

@jdemeyer and @vstinner: Backport status check is done, and it's a failure ❌ .

Copy link
Member

vstinner commented Sep 7, 2018

ISO C89 forbids mixed declaration and code. I wrote PR #9091 to move the "descrgetfunc local_get;" declaration.

vstinner closed this Sep 7, 2018
miss-islington deleted the backport-8f73548-2.7 branch September 7, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants