There was a problem hiding this comment.
Looks good! Thank you - I'll even use it ;-)
There was a problem hiding this comment.
There are following technical problems with current changes:
None, but passing None is not the same as omitting the initial argument.accumulate iterator loses the initial value.|
When you're done making the requested changes, leave the comment: |
|
The pickling and copying should be a separate tracker item for Kristjan Jonnson to update his own code (I think he is the only user of that feature and would be willing to shoulder some of the recurring maintenance burden arising from that code). |
|
I don't think that ignoring |
|
It depends on whether you think None would be a useful input value to an accumulation. The |
|
This will make a subtle difference between As for the pure python version in the docs, the pure python version of |
|
Added pickle support (when initial is set, use |
There was a problem hiding this comment.
Please add an entry in What's New.
| lz->initial, lz->it); | ||
| if (it == NULL) | ||
| return NULL; | ||
| return Py_BuildValue("O(OO)O", Py_TYPE(lz), |
There was a problem hiding this comment.
IMO this is to minor to warrant a WhatsNew entry. Whatsnew should be much more selective. The reason we have whatsnew is that NEWS is already unmanageably lengthy to read.
| if (it == NULL) | ||
| return NULL; | ||
| return Py_BuildValue("O(OO)O", Py_TYPE(lz), | ||
| it, lz->binop?lz->binop:Py_None, Py_None); |
There was a problem hiding this comment.
Please add spaces around ? and : for PEP 7.
There was a problem hiding this comment.
It's better without the spaces to show the grouping and for consistency with the surrounding code.
|
The pickling part LGTM. But I think that |
|
Serhiy, thank you for the suggestion about Let's clear the way for Lisa to apply her first patch own her own. Please clear the review request so this can move forward. It has already consumed far too much time in relative to the value of the feature. |
|
This feature is just too complex for its value. |
https://bugs.python.org/issue34659
https://bugs.python.org/issue34659