[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

1st1 commented Sep 21, 2018 •
edited
Loading

  • Note: if this PR is accepted I'll update the docs before merging it.

https://bugs.python.org/issue34762

vstinner approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member Author

1st1 commented Sep 21, 2018

@elprans Please take a look at the docs update (and PR in general).

Copy link
Member Author

1st1 commented Sep 21, 2018

This is how the docs section looks when rendered:

elprans approved these changes Sep 21, 2018
View reviewed changes
1st1 merged commit 2ec872b into python:master Sep 21, 2018
Copy link
Contributor

miss-islington commented Sep 21, 2018

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

1st1 deleted the fix567 branch September 21, 2018 19:34
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 21, 2018
bpo-34762: Fix contextvars C API to use PyObject* pointer types. (pyt…
54e4a89 
…honGH-9473)

(cherry picked from commit 2ec872b)

Co-authored-by: Yury Selivanov <yury@magic.io>
Copy link

bedevere-bot commented Sep 21, 2018

GH-9478 is a backport of this pull request to the 3.7 branch.

Copy link
Member Author

1st1 commented Sep 21, 2018

Thanks everybody for reviews!

miss-islington added a commit that referenced this pull request Sep 21, 2018
bpo-34762: Fix contextvars C API to use PyObject* pointer types. (GH-…
187f2dd 
…9473)

(cherry picked from commit 2ec872b)

Co-authored-by: Yury Selivanov <yury@magic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

asvetlov asvetlov approved these changes

rhettinger rhettinger approved these changes

+1 more reviewer

elprans elprans approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants