[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

aixtools commented Oct 4, 2018

Ensure values set for compiler.executables are set to None when the value being set is the equivalent of a zero-length string.

https://bugs.python.org/issue34897

…ue} when

the value to be assigned is equivalent to NULL is set to {key:None}
	modified:   Lib/distutils/ccompiler.py
Copy link
Contributor Author

aixtools commented Oct 4, 2018

I hope the review will forgive the Azure pipeline failure: Unexpected vmImage 'vs2017-win2017'

In short, this issue is one I found while research issue11191. As the root_cause is not compiler or platform specific it is better to seperate the two.

Although unlikely on a GNU system, this will occur on any system that does not have CXX defined either during build or runtime - or for any of the other compiler.executables definitions.

Hope this help clarify the justification for this PR.

ncoghlan changed the title bpo-34897: Fix Lib/distutils/ccompiler.py def set_executables() bpo-34897: distutils test errors when CXX is not set Dec 26, 2018
Copy link
Contributor

ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting for the new CI run that was triggered by my rewording of the NEWS entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants