[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

pablogsal commented Oct 9, 2018 •
edited by bedevere-bot
Loading

pablogsal self-assigned this Oct 9, 2018
pablogsal mentioned this pull request Oct 9, 2018
Merged
serhiy-storchaka reviewed Oct 10, 2018
View reviewed changes
Lib/test/_test_multiprocessing.py Outdated
os.kill(pid, signal.SIGKILL)
os.waitpid(pid, 0)
with warnings.catch_warnings(record=True) as all_warn:
warnings.simplefilter("always")
Copy link
Member

serhiy-storchaka Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the recorded warnings just ignored?

serhiy-storchaka approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing warnings!

pablogsal merged commit 3058b7d into python:master Oct 10, 2018
pablogsal deleted the 33613-2 branch October 10, 2018 07:40
Copy link
Member Author

pablogsal commented Oct 10, 2018

Thank you for the catch and the review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants