[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Oct 15, 2018 •
edited by bedevere-bot
Loading

python-gdb.py now handles errors on computing the line number
of a Python frame.

Changes:

  • PyFrameObjectPtr.current_line_num() now catchs any Exception on
    calling addr2line(), instead of failing with a surprising "<class
    'TypeError'> 'FakeRepr' object is not subscriptable" error.
  • All callers of current_line_num() now handle current_line_num()
    returning None.
  • PyFrameObjectPtr.current_line() now also catchs IndexError on
    getting a line from the Python source file.
    (cherry picked from commit 2e438cc)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue34989

bpo-34989: python-gdb.py: fix current_line_num() (pythonGH-9889)
360ca2b 
python-gdb.py now handles errors on computing the line number
of a Python frame.

Changes:

* PyFrameObjectPtr.current_line_num() now catchs any Exception on
  calling addr2line(), instead of failing with a surprising "<class
  'TypeError'> 'FakeRepr' object is not subscriptable" error.
* All callers of current_line_num() now handle current_line_num()
  returning None.
* PyFrameObjectPtr.current_line() now also catchs IndexError on
  getting a line from the Python source file.
(cherry picked from commit 2e438cc)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
bedevere-bot mentioned this pull request Oct 15, 2018
Merged
vstinner approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Copy link
Contributor Author

miss-islington commented Oct 15, 2018

@vstinner: Status check is done, and it's a success ✅ .

miss-islington merged commit fcea3dd into python:3.7 Oct 15, 2018
miss-islington deleted the backport-2e438cc-3.7 branch October 15, 2018 21:48
Copy link
Contributor Author

miss-islington commented Oct 15, 2018

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants