[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

srinivasreddy commented Oct 16, 2018 •
edited by bedevere-bot
Loading

pppery reviewed Oct 18, 2018
View reviewed changes
ericvsmith requested changes Oct 18, 2018
View reviewed changes
Copy link
Member

ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! See my comments.

Copy link

bedevere-bot commented Oct 18, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Contributor Author

srinivasreddy commented Oct 19, 2018

I have made the requested changes; please review again

Copy link

bedevere-bot commented Oct 19, 2018

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

ericvsmith requested changes Oct 19, 2018
View reviewed changes
Copy link
Member

ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srinivasreddy, for the quick turnaround.

I have a few small comments. I know they seem insignificant, but it's the same standard that I'd hold myself to, so you get to be the victim of my nitpicking. Thanks in advance.

Copy link

bedevere-bot commented Oct 19, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Contributor Author

srinivasreddy commented Oct 19, 2018

I have made the requested changes; please review again

Copy link

bedevere-bot commented Oct 19, 2018

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

ericvsmith approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member

ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for your work!

ericvsmith merged commit dd13c88 into python:master Oct 19, 2018
Copy link
Contributor

miss-islington commented Oct 19, 2018

Thanks @srinivasreddy for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

Copy link
Contributor

miss-islington commented Oct 19, 2018

Sorry, @srinivasreddy and @ericvsmith, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dd13c88b5371e13fc16b84e2f9b8715d917de269 3.6

Copy link
Contributor

miss-islington commented Oct 19, 2018

Thanks @srinivasreddy for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

srinivasreddy deleted the 33947_dataclasses branch October 19, 2018 17:19
serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 and removed needs backport to 3.7 labels Oct 31, 2018
Copy link
Contributor

miss-islington commented Oct 31, 2018

Thanks @srinivasreddy for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

Copy link
Contributor

miss-islington commented Oct 31, 2018

Sorry, @srinivasreddy and @ericvsmith, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dd13c88b5371e13fc16b84e2f9b8715d917de269 3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericvsmith ericvsmith approved these changes

+1 more reviewer

pppery pppery left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

ericvsmith

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants