[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36974: Fix GDB integration #13665

Merged
merged 1 commit into from May 29, 2019
Merged

bpo-36974: Fix GDB integration #13665

merged 1 commit into from May 29, 2019

Conversation

Copy link
Member

encukou commented May 29, 2019 •
edited by bedevere-bot

buildbot fix for #13185

As it changes the way functions are called, the PEP 590 implementation
skipped the functions that the GDB integration is looking for
(by name) to find function calls.

Looking for the new helper cfunction_call_varargs should fix buildbots.

The changed frame nuber in test_gdb is due to there being fewer
C calls when calling a built-in funciton/method.

https://bugs.python.org/issue36974

bpo-36974: Fix GDB integration
2e8bc0e 
As it changes the way functions are called, the PEP 590 implementation
skipped the functions that the GDB integration is looking for
(by name) to find function calls.

Looking for the new helper `cfunction_call_varargs` hopefully fixes the
tests, and thus buildbots.

The changed frame nuber in test_gdb is due to there being fewer
C calls when calling a built-in method.
Copy link
Contributor

jdemeyer commented May 29, 2019

Could you change this comment:

        # Tested function must not be defined with METH_NOARGS or METH_O,
        # otherwise call_function() doesn't call PyCFunction_Call()

Copy link
Member Author

encukou commented May 29, 2019 •
edited

I'm planning a follow-up with a better fix; I'll change the comment there. This is a quick patch to fix the buildbots.

encukou merged commit fecb75c into python:master May 29, 2019
encukou deleted the pep590 branch May 29, 2019
Copy link
Contributor

jdemeyer commented May 29, 2019

Thanks a lot (assuming that this actually fixes the buildbots)!

Copy link
Member Author

encukou commented May 29, 2019

It dit! 🎉

And #13668 is that follow-up.

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-36974: Fix GDB integration (pythonGH-13665)
804b144 
As it changes the way functions are called, the PEP 590 implementation
skipped the functions that the GDB integration is looking for
(by name) to find function calls.

Looking for the new helper `cfunction_call_varargs` hopefully fixes the
tests, and thus buildbots.

The changed frame nuber in test_gdb is due to there being fewer
C calls when calling a built-in method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants