[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings #13758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 1 commit into from
Jun 2, 2019
Merged

bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings #13758

encukou merged 1 commit into from
Jun 2, 2019

Conversation

Copy link
Member

encukou commented Jun 2, 2019 •
edited
Loading

encukou merged commit e584cbf into python:master Jun 2, 2019
encukou deleted the warning-fix branch June 2, 2019 23:08
encukou commented Jun 3, 2019
View reviewed changes
Objects/longobject.c
Py_DECREF(c);
Py_DECREF(n);
if (long_compare(a, _PyLong_One)) {
if (long_compare(a, (PyObject *)_PyLong_One)) {
Copy link
Member Author

encukou Jun 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, it should be PyLongObject.
#13761 is the proper fix.

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings (
eb7a086 
pythonGH-13758)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants