[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35081: Internal headers require Py_BUILD_CORE #10363

Merged
merged 2 commits into from Nov 9, 2018
Merged

bpo-35081: Internal headers require Py_BUILD_CORE #10363

merged 2 commits into from Nov 9, 2018

Conversation

Copy link
Member

vstinner commented Nov 6, 2018 •
edited by bedevere-bot

Modify internal header files to fail if Py_BUILD_CORE is not defined.

https://bugs.python.org/issue35081

vstinner requested a review from 1st1 as a code owner Nov 6, 2018
Copy link
Member Author

vstinner commented Nov 6, 2018

I tried to modify pycore_accu.h, but it broke the compilation of the _json module:
https://mail.python.org/pipermail/python-dev/2018-November/155688.html

I don't understand what is Py_BUILD_CORE_BUILTIN and how it should be used.

bpo-35081: Internal headers require Py_BUILD_CORE
ca38507 
* All internal header files now require Py_BUILD_CORE or
  Py_BUILD_CORE_BUILTIN to be defined.
* _json.c is now compiled with Py_BUILD_CORE_BUILTIN to access
  pycore_accu.h header.
vstinner changed the title [WIP] bpo-35081: More internal headers require Py_BUILD_CORE bpo-35081: Internal headers require Py_BUILD_CORE Nov 9, 2018
Modules/Setup: add example for _json
729ff29 
Add an example to show how to build _json as a built-in module.
It requires non trivial compiler options.
vstinner merged commit 130893d into python:master Nov 9, 2018
vstinner deleted the need_build_pycore branch Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

1st1

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants