[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35081: Move bytes_methods.h to the internal C API #18492

Merged
merged 1 commit into from Feb 12, 2020
Merged

bpo-35081: Move bytes_methods.h to the internal C API #18492

merged 1 commit into from Feb 12, 2020

Conversation

Copy link
Member

vstinner commented Feb 12, 2020 •
edited by bedevere-bot

Move the bytes_methods.h header file to the internal C API as
pycore_bytes_methods.h: it only contains private symbols (prefixed by
"_Py"), except of the PyDoc_STRVAR_shared() macro.

https://bugs.python.org/issue35081

bpo-35081: Move bytes_methods.h to the internal C API
32f0987 
Move the bytes_methods.h header file to the internal C API as
pycore_bytes_methods.h: it only contains private symbols (prefixed by
"_Py"), except of the PyDoc_STRVAR_shared() macro.
vstinner requested a review from a team as a code owner Feb 12, 2020
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #18492 into master will increase coverage by 1.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #18492       +/-   ##
===========================================
+ Coverage   82.11%   83.19%    +1.08%     
===========================================
  Files        1956     1571      -385     
  Lines      589183   414643   -174540     
  Branches    44448    44449        +1     
===========================================
- Hits       483833   344981   -138852     
+ Misses      95701    60016    -35685     
+ Partials     9649     9646        -3
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 430 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674935b...32f0987. Read the comment docs.

vstinner merged commit 45876a9 into python:master Feb 12, 2020
vstinner deleted the pycore_bytes_methods branch Feb 12, 2020
sthagen added a commit to sthagen/python-cpython that referenced this pull request Feb 12, 2020
Merge pull request #246 from python/master
70c39ff 
bpo-35081: Move bytes_methods.h to the internal C API (pythonGH-18492)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

windows-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants