Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| &tuplegetter_type, | ||
| }; | ||
|
|
||
| for (int i = 0; typelist[i] != NULL; i++) { |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
@vstinner I'd like to create a new helper function for this.
This logic can be reused.
https://github.com/python/cpython/blob/514c469719f149e1722a91a9d0c63bf89dfefb2a/Modules/itertoolsmodule.c#L4733L4747
What do you think?
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Do you mean combine PyType_Ready + _PyType_Name + PyModule_AddObject? Yeah, maybe it's worth it, but I would prefer to add it once this PR lands.
58e7344 to
fb35d81
Compare
| &PyODict_Type, | ||
| &dequeiter_type, | ||
| &dequereviter_type, | ||
| &tuplegetter_type, |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Either you use Py_ARRAY_COUNT() to get the list length, or you need to add a NULL terminator. Currently, you rely on an undefined behavior.
|
FWIW, some comments in https://github.com/python/cpython/pull/18066/files |
https://bugs.python.org/issue1635741