Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also make getchildren() and getiterator() emitting a DeprecationWarning instead of PendingDeprecationWarning.
37b9b3b
to
3207edc
Compare
| warnings.warn( | ||
| "This method will be removed in future versions. " | ||
| "Use 'tree.iter()' or 'list(tree.iter())' instead.", | ||
| PendingDeprecationWarning, stacklevel=2 | ||
| DeprecationWarning, stacklevel=2 |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Do you want to update the messages to have the version since the deprecation and the planned removal version here (and on line 418) ?
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
It is in the documentation.
| warnings.warn( | ||
| "The doctype() method of XMLParser is ignored. " | ||
| "Define doctype() method on the TreeBuilder target.", | ||
| RuntimeWarning) |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Same here add versions ?
Also make getchildren() and getiterator() emitting a DeprecationWarning instead of PendingDeprecationWarning.
https://bugs.python.org/issue29209