Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| @@ -0,0 +1,3 @@ | |||
| math.factorial no longer accept arguments that are not int-like. A | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry for nit-picking a bit. But
"math.factorial no longer accepts arguments.." (accept -> accepts).
emmited -> emitted
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :)
| } | ||
| else{ | ||
| pyint_form = PyNumber_Index(arg); | ||
| if( pyint_form == NULL){ |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Fix the spacing on this and the next line.
|
When you're done making the requested changes, leave the comment: |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @taleinat: please review the changes made to this pull request. |
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be poked with soft cushions! |
|
I have made the requested changes; please review again. Thank you for the whitespace fix! |
|
Thanks for making the requested changes! @taleinat: please review the changes made to this pull request. |
a449b46
to
4b465a4
Compare
…deprecation warning for floats
pythonGH-6149) math.factorial() was accepting non-integral Decimal instances. This is inconsistent with the actual behaviour for floats, which are not accepted.
https://bugs.python.org/issue33083