[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ mypy Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect "unused 'type: ignore' comment" error log coloring #8248

Merged
merged 1 commit into from Jan 6, 2020
Merged

Fix incorrect "unused 'type: ignore' comment" error log coloring #8248

merged 1 commit into from Jan 6, 2020

Conversation

Copy link
Collaborator

TH3CHARLie commented Jan 6, 2020

fixes #8242

Original error code indexing is assuming all `msg's included a '[', which clearly fails on "unused 'type: ignore' comment", this PR provides correct string finding and substring indexing thus a correct colorization.

However, it also seems meaningful to add an error code for this error. Suggestions are welcomed.

TH3CHARLie mentioned this pull request Jan 6, 2020
Closed
msullivan approved these changes Jan 6, 2020
View changes
Copy link
Collaborator

msullivan left a comment

Thanks!

msullivan merged commit 7c5e69b into python:master Jan 6, 2020
TH3CHARLie deleted the fix-8242 branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

msullivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused type: ignore error log coloring bug when using show-error-codes
2 participants