[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ mypy Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common issues to include __init__ without arguments #8303

Merged
merged 3 commits into from Jan 25, 2020
Merged

Update common issues to include __init__ without arguments #8303

merged 3 commits into from Jan 25, 2020

Conversation

Copy link
Contributor

le0tan commented Jan 19, 2020

This is the implication of #5677 where the return type of __init__ is inferred given that at least one argument is typed.

However, if no argument is present in __init__, -> None becomes compulsory if we are to enable type-checking on that method without using --check-untyped-defs flag. I believe it is worth mentioning in the section of "No errors reported for obviously wrong code".

Mention __init__ without arguments in misc...
82913aa 
- common issues and solutions -> No errors reported for obviously wrong
code
le0tan requested a review from JukkaL Jan 19, 2020
Copy link
Contributor Author

le0tan commented Jan 19, 2020

This should close #8289 as well.

ilevkivskyi approved these changes Jan 25, 2020
View changes
Copy link
Member

ilevkivskyi left a comment

Great, thanks! (I just made one minor formatting tweak.)

ilevkivskyi merged commit 41b40aa into python:master Jan 25, 2020
ilevkivskyi mentioned this pull request Jan 25, 2020
Closed
sthagen added a commit to sthagen/python-mypy that referenced this pull request Jan 26, 2020
Merge pull request #15 from python/master
c8de91e 
Update common issues to include __init__ without arguments (python#8303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

ilevkivskyi

JukkaL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants